remove bech32 ibc #1994
Merged
remove bech32 ibc #1994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't fully remove bech32 ibc repo as a dependency because its used in the v5 upgrade code. Is it okay to remove old upgrade migrations from newer code releases? |
|
yeah, just comment out those lines (comment out import as well please) |
ValarDragon
approved these changes
Jul 7, 2022
There was a problem hiding this comment.
LGTM.
E2E test atm covers sends working AFAIK, so should be confident things are still working. CC'ing @p0mvn to confirm
p0mvn
approved these changes
Jul 7, 2022
There was a problem hiding this comment.
LGTM - yes as long as e2e tests pass, this should be safe IMO
Sanity checked IBC token transfer e2e test in CI: https://github.com/osmosis-labs/osmosis/runs/7238675443?check_suite_focus=true#step:9:124 . Looks good
mattverse
pushed a commit
that referenced
this pull request
Jul 20, 2022
* remove bech32 ibc * comment out in v5 upgrade code * CHANGELOG
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
This PR removes bech32 ibc from the state machine, because it is unmaintained.
Brief Changelog
(for example:)
Testing and Verifying
(Please pick one of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? (yes / no)x/<module>/spec/) / Osmosis docs repo / not documented)